github-actions[bot] commented on code in PR #64028:
URL: https://github.com/apache/doris/pull/64028#discussion_r3340459182
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergUtils.java:
##########
@@ -1128,9 +1128,12 @@ public static String dataLocation(Table table) {
}
String dataLocation =
properties.get(TableProperties.WRITE_DATA_LOCATION);
if (dataLocation == null) {
- dataLocation =
properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION);
+ dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH);
Review Comment:
This now applies `object-store.path` whenever `write.data.path` is absent,
even when the table is not using Iceberg's object-store location provider. In
Iceberg 1.10.1, `DefaultLocationProvider` ignores `object-store.path` and uses
`write.folder-storage.path` or `<table>/data`; `object-store.path` is only
checked after `object-store.enabled=true` selects
`ObjectStoreLocationProvider`. A table that has `object-store.path` left in its
properties but has `object-store.enabled` absent/false will now make Doris
INSERT/DELETE/MERGE sinks write files under `object-store.path` instead of the
actual default-provider data location. Please gate this branch on
`TableProperties.OBJECT_STORE_ENABLED` (or mirror
`LocationProviders.locationsFor`) and add a test where `OBJECT_STORE_PATH` and
`WRITE_FOLDER_STORAGE_LOCATION` are both present but object-store mode is
disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
