github-actions[bot] commented on code in PR #61518:
URL: https://github.com/apache/doris/pull/61518#discussion_r3340653060
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/PluginDrivenSplit.java:
##########
@@ -72,6 +72,9 @@ private static List<String>
buildPartitionValues(ConnectorScanRange scanRange) {
if (partValues == null || partValues.isEmpty()) {
return null;
}
- return new ArrayList<>(partValues.values());
Review Comment:
This sorts only the partition values, but
`FileQueryScanNode.splitToScanRange()` later pairs
`fileSplit.getPartitionValues()` with `pathPartitionKeys` (the table
partition-key order) when calling `buildPartitionKeyValues(columnsFromPathKeys,
columnsFromPath)`. If a connector returns `{dt=20260319, country=cn}` for a
table whose partition keys are `[dt, country]`, this sorted value list becomes
`[cn, 20260319]`, and BE receives `dt=cn/country=20260319`. Please preserve the
same key order as `pathPartitionKeys`, or pass ordered key/value pairs through
the split instead of sorting values independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
