github-actions[bot] commented on code in PR #64009:
URL: https://github.com/apache/doris/pull/64009#discussion_r3345564093
##########
fe/fe-filesystem/fe-filesystem-cos/src/main/java/org/apache/doris/filesystem/cos/CosObjStorage.java:
##########
@@ -107,7 +107,7 @@ static Map<String, String> toS3Props(Map<String, String>
cosProps) {
if (cosProps.containsKey("COS_ROLE_ARN") &&
!cosProps.containsKey("AWS_ROLE_ARN")) {
s3Props.put("AWS_ROLE_ARN", cosProps.get("COS_ROLE_ARN"));
}
- s3Props.put("use_path_style", "false");
+ s3Props.putIfAbsent("use_path_style", "false");
Review Comment:
This still drops the supported path-style alias `s3.path-style-access`.
`S3FileSystemProperties` declares `@ConnectorProperty(names = {USE_PATH_STYLE,
"s3.path-style-access"})`, and
`ConnectorPropertiesUtils.getMatchedPropertyName` picks the first present name.
If a COS/OBS/OSS caller sets only `s3.path-style-access=true`, this line
inserts `use_path_style=false`; the binder then sees the canonical key first
and ignores the alias, so `S3ObjStorage.isUsePathStyle()` remains false and
path-style HTTP URLs are parsed as virtual-hosted. Please only default when
neither alias is present, or normalize `s3.path-style-access` into
`use_path_style` before defaulting, and apply the same fix in the OBS/OSS
translation/provider paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
