github-actions[bot] commented on code in PR #64034:
URL: https://github.com/apache/doris/pull/64034#discussion_r3345569980
##########
fe/fe-filesystem/fe-filesystem-cos/src/main/java/org/apache/doris/filesystem/cos/CosFileSystemProvider.java:
##########
@@ -61,7 +61,7 @@ public FileSystem create(Map<String, String> properties)
throws IOException {
if (properties.containsKey("COS_SECRET_KEY")) {
props.put("AWS_SECRET_KEY", properties.get("COS_SECRET_KEY"));
}
- props.put("use_path_style", "false");
+ props.putIfAbsent("use_path_style", "false");
Review Comment:
This still drops an explicit path-style setting when the caller uses the
supported alias `s3.path-style-access=true`. `S3FileSystemProperties` binds
`use_path_style` before `s3.path-style-access`, so adding
`use_path_style=false` here makes the alias evaluate to false. The same pattern
exists in the COS/OBS/OSS providers and their `toS3Props` helpers, so a user
can still lose an explicit path-style request unless the default is added only
when neither `use_path_style` nor `s3.path-style-access` is present. Please fix
all three providers/helpers and add a test for the alias path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
