github-actions[bot] commented on code in PR #63181: URL: https://github.com/apache/doris/pull/63181#discussion_r3345792610
########## extension/logstash/logstash-output-doris.gemspec: ########## @@ -46,5 +46,10 @@ Gem::Specification.new do |s| s.add_development_dependency 'sinatra', '~> 1.4' s.add_development_dependency 'webrick', '~> 1.9' - s.requirements << 'jar org.apache.httpcomponents.client5, httpclient5, 5.4.2' + # JARs are vendored under lib/; the corresponding require_jar calls live in + # lib/logstash-output-doris_jars.rb. We deliberately do NOT add a Review Comment: This removes the only dependency metadata that causes `jar-dependencies` to generate/package the jar loader, but `lib/logstash/outputs/doris.rb` still unconditionally does `require ".../logstash-output-doris_jars.rb"`. In this checkout there is no `lib/logstash-output-doris_jars.rb` and no vendored `lib/org`/`lib/com` jars (they are gitignored), and running the documented `gem build logstash-output-doris.gemspec` produces a gem whose `lib/` contains only `logstash/`. Installing that gem will therefore fail at plugin load time before any of the new HttpClient4 code can run. Please either keep dependency requirements/generation for HttpClient4 and its transitive jars, or add a committed/release build step that vendors `logstash-output-doris_jars.rb` plus the required jars into `s.files`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
