yiguolei commented on code in PR #63919:
URL: https://github.com/apache/doris/pull/63919#discussion_r3346294520
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
Review Comment:
你这个改法，改动会很大。
你可以这么改：在session var 里继续保留 string 类型；
然后写一个check 方法，类似
@VarAttrDef.VarAttr(name = QUERY_TIMEOUT, needForward = true,
checker = "checkQueryTimeoutValid", setter = "setQueryTimeoutS")
private int queryTimeoutS = 900;
保证写入的string 一定是符合enum 要求的，也就是你这个parse 方法里的东西。
然后写一个get 方法，返回enum 就ok了。 这样其他序列化的地方都不需要处理了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
