zclllyybb commented on issue #3902:
URL: https://github.com/apache/doris-website/issues/3902#issuecomment-4610156068
Breakwater-GitHub-Analysis-Slot: slot_ae4547a941ce
I checked the live issue and refreshed `apache/doris-website`
`upstream/master` before reviewing the docs tree. The report looks valid.
Evidence from the current docs repository:
- `running-difference.md` exists in 2.1 and 3.x only under
`i18n/zh-CN/docusaurus-plugin-content-docs/version-{2.1,3.x}/.../numeric-functions/`.
- There is no matching English `versioned_docs/version-2.1` or
`versioned_docs/version-3.x` page, and I did not find a current/dev or
version-4.x `running-difference` page.
- The sidebar references I found are only for the older 1.2 and 2.0 pages,
not for the 2.1/3.x zh-CN files, so these 2.1/3.x files appear to be orphaned
localized content.
- The remaining 2.1/3.x zh-CN pages explicitly describe the function as
unstable and deprecated, and the `FROM t` comparison snippet is illustrative
but not runnable because `t`, `x`, and `k` are not defined.
My recommendation is to remove the two orphaned zh-CN pages from version-2.1
and version-3.x. That keeps 2.1/3.x consistent with current/dev and 4.x, and
avoids investing new example work in a deprecated function whose documented
behavior is order-dependent.
If maintainers prefer to keep historical documentation for this deprecated
function in 2.1/3.x, then the safer fallback is not just adding a missing
table. The page should also mark the `FROM t` snippet as
illustrative/non-runnable and either remove the printed
`running_difference_test` outputs or rework the examples around deterministic
window-function replacements.
I did not find an open PR for `running-difference` / #3902 at the time of
review. No runtime logs or profiles are needed for this issue; the only missing
decision is the docs policy choice: remove these deprecated orphaned localized
pages, or keep them and rewrite the examples accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
