github-actions[bot] commented on code in PR #63543:
URL: https://github.com/apache/doris/pull/63543#discussion_r3346937895
##########
fs_brokers/cdc_client/src/test/java/org/apache/doris/cdcclient/source/deserialize/DebeziumJsonDeserializerTest.java:
##########
@@ -73,4 +74,46 @@ private Object invokeConvertTimestamp(String typeName,
Object dbzObj) {
throw new RuntimeException(e);
}
}
+
+ // ─── convertZoneTime
──────────────────────────────────────────────────────
+ // timetz arrives as a UTC-normalized ISO string; the method renders it to
+ // serverTimeZone (mirrors timestamptz) and emits an offset-less wall
clock.
+
+ @Test
+ void zoneTime_utc_keepsUtcWallClock() {
+ deserializer.setServerTimeZone(ZoneId.of("UTC"));
Review Comment:
These new `convertZoneTime` assertions still expect the old behavior (shift
into `serverTimeZone` and drop the offset), but the current implementation now
returns the Debezium `ZonedTime` string unchanged at
`DebeziumJsonDeserializer.convertZoneTime`. For this case the method returns
`12:00:00.123456Z`, not `12:00:00.123456`; the `+08`, `-05`, and whole-second
assertions below similarly expect shifted/trimmed values that the
implementation no longer produces. This makes the added unit test fail and also
documents semantics opposite to the regression `.out` files that now expect
preserved `Z` offsets. Please update these tests/comments to assert the
preserved offset-bearing string (or change the implementation back, but that
would conflict with the updated regression expectations).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
