github-actions[bot] commented on code in PR #64120:
URL: https://github.com/apache/doris/pull/64120#discussion_r3356170422
##########
be/src/core/cow.h:
##########
@@ -320,6 +320,7 @@ class COW {
// uniquely owned. This does not detach shared owners; use a type-specific
// COW entry point (for example IColumn::mutate) when the pointer may be
// shared.
+ MutablePtr assert_mutable() = delete;
Review Comment:
This deletion leaves existing direct calls on non-const column objects in
the tree, so BE UT compilation will fail. For example,
`be/test/format/native/native_reader_writer_test.cpp` still has
`data.assert_mutable()` at line 101, `keys.assert_mutable()` /
`values.assert_mutable()` at lines 147-148, and the same pattern later in the
file. With this non-const overload deleted, overload resolution selects the
deleted function for those expressions instead of the const overload. Please
update those remaining call sites (or otherwise keep a compiling compatibility
path) before deleting the overload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
