yujun777 commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3361113253
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -895,12 +897,19 @@ private static List<RewriteJob> getWholeTreeRewriteJobs(
ImmutableSet.of(LogicalCTEAnchor.class),
() -> {
List<RewriteJob> rewriteJobs =
Lists.newArrayListWithExpectedSize(300);
- rewriteJobs.add(
- topic("normalize olap table stream scan",
-
custom(RuleType.NORMALIZE_OlAP_TABLE_STREAM_SCAN,
- NormalizeOlapTableStreamScan::new)
- )
- );
+ if (Config.enable_table_stream) {
Review Comment:
`NormalizeOlapTableBinlogScan` is also needed for base-table `@incr(...)`
scans, but this whole block is gated by `Config.enable_table_stream`.
`BindRelation` accepts `table@incr(...)` based on row binlog requirements and
does not require `enable_table_stream`, so with binlog enabled but table stream
disabled the change scan can skip normalization.
In that case the scan remains non-incremental; `OlapScanNode` will set
start/end timestamp in the `hasChangeScan` branch but will not set
`binlog_scan_type`, so DETAIL/MIN_DELTA/APPEND_ONLY semantics depend on BE
defaults. Either `@incr` should be gated by the same config, or the binlog
normalize rule should run independently of table stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
