HappenLee commented on code in PR #64039:
URL: https://github.com/apache/doris/pull/64039#discussion_r3361326902
##########
be/src/udf/python/python_udf_runtime.cpp:
##########
@@ -47,29 +79,51 @@ void PythonUDFProcess::remove_unix_socket() {
void PythonUDFProcess::shutdown() {
if (!_child.valid() || _is_shutdown) return;
- _child.terminate();
- bool graceful = false;
- constexpr std::chrono::milliseconds retry_interval(100); // 100ms
-
- for (int i = 0; i < TERMINATE_RETRY_TIMES; ++i) {
- if (!_child.running()) {
- graceful = true;
- break;
- }
- std::this_thread::sleep_for(retry_interval);
+ constexpr std::chrono::milliseconds terminate_timeout(1000);
Review Comment:
PROCESS_TERMINATE_TIMEOUT 这里是不是应该用这个变量
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
