Tanya-W commented on code in PR #13035:
URL: https://github.com/apache/doris/pull/13035#discussion_r1057229781
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -373,6 +392,145 @@ Status SegmentIterator::_apply_bitmap_index() {
return Status::OK();
}
+bool SegmentIterator::_is_literal_node(const TExprNodeType::type& node_type) {
+ switch (node_type) {
+ case TExprNodeType::BOOL_LITERAL:
+ case TExprNodeType::INT_LITERAL:
+ case TExprNodeType::LARGE_INT_LITERAL:
+ case TExprNodeType::FLOAT_LITERAL:
+ case TExprNodeType::DECIMAL_LITERAL:
+ case TExprNodeType::STRING_LITERAL:
+ case TExprNodeType::DATE_LITERAL:
+ return true;
+ default:
+ return false;
+ }
+}
+
+Status SegmentIterator::_execute_all_compound_predicates(vectorized::VExpr*
expr) {
+ if (expr == nullptr) {
+ return Status::OK();
+ }
+
+ auto children = expr->children();
+ for (int i = 0; i < children.size(); ++i) {
+ RETURN_IF_ERROR(_execute_all_compound_predicates(children[i]));
+ }
+
+ auto node_type = expr->node_type();
+ if (node_type == TExprNodeType::SLOT_REF) {
+ _column_predicate_info->column_name = expr->expr_name();
+ } else if (_is_literal_node(node_type)) {
+ auto v_literal_expr =
dynamic_cast<doris::vectorized::VLiteral*>(expr);
+ _column_predicate_info->query_value = v_literal_expr->value();
+ } else if (node_type == TExprNodeType::BINARY_PRED) {
+ _column_predicate_info->query_op = expr->fn().name.function_name;
+ // get child condition result in compound condtions
+ auto column_sign = _gen_predicate_sign(_column_predicate_info.get());
+ _column_predicate_info.reset(new ColumnPredicateInfo());
+ if (_rowid_result_for_index.count(column_sign) > 0
+ && _rowid_result_for_index[column_sign].first) {
+ auto apply_reuslt = _rowid_result_for_index[column_sign].second;
+ _compound_predicate_execute_result.push_back(apply_reuslt);
+ }
Review Comment:
no need else branch, can use _compound_predicate_execute_result size to
decide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
