CalvinKirs commented on code in PR #60921:
URL: https://github.com/apache/doris/pull/60921#discussion_r3363551053
##########
fe/fe-core/src/main/java/org/apache/doris/master/MetaHelper.java:
##########
@@ -149,9 +149,13 @@ private static void checkFile(File file) throws
IOException {
public static <T> ResponseBody doGet(String url, int timeout, Class<T>
clazz) throws IOException {
Map<String, String> headers = HttpURLUtil.getNodeIdentHeaders();
- LOG.info("meta helper, url: {}, timeout{}, headers: {}", url, timeout,
headers);
+ LOG.debug("meta helper, url: {}, timeout: {}, headers: {}", url,
timeout, headers);
String response = HttpUtils.doGet(url, headers, timeout);
Review Comment:
HTTP request logs are for audit purposes — don't guard them with
debugEnable. Use log.Info instead.↳
For debug logs, always wrap with if debugEnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
