github-actions[bot] commented on code in PR #64027:
URL: https://github.com/apache/doris/pull/64027#discussion_r3366632511
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java:
##########
@@ -1045,7 +1044,6 @@ public class BuiltinScalarFunctions implements
FunctionHelper {
scalar(Sin.class, "sin"),
scalar(Sinh.class, "sinh"),
scalar(Sleep.class, "sleep"),
- scalar(StructElement.class, "struct_element"),
Review Comment:
Dropping the `struct_element` builtin name is a user-visible incompatible
change. Existing SQL, views, prepared statements, and clients can call
`struct_element(...)` today, and this PR also removes the BE
implementation/registration, so those queries will fail after upgrade rather
than being routed to the unified `element_at` implementation. The existing
review thread about merging the two functions does not require removing the old
public name; please keep `struct_element` as a FE/BE alias (or compatibility
wrapper) that resolves to the same implementation, and keep at least one
regression case proving the old name still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
