yx-keith opened a new pull request, #64183:
URL: https://github.com/apache/doris/pull/64183
The BRACKETED_COMMENT lexer rule allowed nested block comments via a
recursive alternative:
BRACKETED_COMMENT : '/*' ( BRACKETED_COMMENT | . )*? '*/'
MySQL / standard SQL block comments do NOT nest: a `/*` is closed by the
first following `*/`. With nesting, a query like
where 1 = 1
/* and id = 2
/* */
and id = 3
-- */
had its outer comment consume both `*/` markers, swallowing `and id = 3` and
silently returning all rows instead of only the matching one.
Drop the recursive alternative so the comment closes at the first `*/`:
BRACKETED_COMMENT : '/*' .*? '*/'
Add a parser unit test (verified to fail under the old nesting grammar and
pass under the fix) and a SQL-level regression test replaying the issue.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
