heguanhui commented on code in PR #64185:
URL: https://github.com/apache/doris/pull/64185#discussion_r3370475449
##########
be/test/core/block/column_complex_test.cpp:
##########
@@ -117,7 +119,7 @@ TEST(ColumnComplexTest, GetDataAtTest) {
ASSERT_EQ(column_bitmap->get_element(1).to_string(),
bitmap_verify_data[0].to_string());
ASSERT_EQ(column_hll->get_element(1).to_string(),
column_hll_verify->get_element(0).to_string());
- ASSERT_EQ(column_quantile_state->get_data_at(1),
column_quantile_state_verify->get_data_at(0));
+ ASSERT_EQ(column_quantile_state->operator[](1),
column_quantile_state_verify->operator[](0));
Review Comment:
column is a pointer, so [1] would be parsed as pointer arithmetic rather
than calling operator[]. ->operator[](1) is equivalent to (*column)[1] — less
idiomatic but functionally correct. All 48 occurrences in this file use the
same style; if changed, they should be unified to (*column)[n].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
