Mryange opened a new pull request, #64203:
URL: https://github.com/apache/doris/pull/64203
### What problem does this PR solve?
This PR extends the const-block validation pattern to pipeline sink
operators. Before this change, DataSinkOperatorXBase::sink() directly forwarded
input blocks to each sink implementation, so sink operators were not
consistently exercised with const-column input and each sink had to implicitly
tolerate the incoming column shape.
Root cause: the public sink wrapper did not own a common const-column
policy. As a result, const handling was fragmented across sink implementations
and debug const-block mocking could not be applied at the sink boundary.
This change moves DataSinkOperatorXBase::sink() into the cpp file and makes
it the shared entry point for sink-side const handling. By default, sink input
blocks are materialized with materialize_block_inplace() before calling
sink_impl(). In debug builds, the wrapper also mocks const-block input once by
splitting an N-row block into N one-row const blocks, preventing recursive
mocking with a sink-local flag.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
