sollhui opened a new pull request, #64221:
URL: https://github.com/apache/doris/pull/64221
### What problem does this PR solve?
`vtablet_writer` and `vtablet_writer_v2` used fixed 10ms polling loops while
waiting for downstream node channels / load streams to finish close or reach
quorum success. When downstream recovery is slow, upstream close wait may
repeatedly scan unfinished channels and consume unnecessary CPU.
This PR changes close wait to an event-driven wakeup model:
- `vtablet_writer`:
- Adds a close wait condition variable and version counter in
`IndexChannel`.
- `VNodeChannel` notifies close wait when the last add-block RPC finishes
or when the channel is cancelled.
- `IndexChannel::close_wait()` waits on the notification instead of
polling every 10ms.
- `vtablet_writer_v2`:
- Adds close wait notification helpers in `LoadStreamStub`.
- Stream close and cancel paths notify close wait.
- `VTabletWriterV2::_close_wait()` waits on stream close events instead of
polling every 10ms.
The existing quorum success logic and max wait timeout behavior are
preserved. A bounded fallback wait is kept so timeout and cancellation state
can still be refreshed even if no downstream event arrives.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
