iaorekhov-1980 commented on code in PR #61440: URL: https://github.com/apache/doris/pull/61440#discussion_r3374683699
########## fe/fe-authentication/fe-authentication-plugins/fe-authentication-plugin-ldap/src/test/java/org/apache/doris/authentication/plugin/ldap/LdapAuthenticationPluginIntegrationTest.java: ########## @@ -22,6 +22,7 @@ import org.apache.doris.authentication.AuthenticationResult; import org.apache.doris.authentication.CredentialType; import org.apache.doris.authentication.Principal; +import org.apache.doris.common.LdapConfig; Review Comment: Hello, Unfortunately I can't remove reference to `LdapConfig` as I need to use it to test compatibility of old mode with new one plugin based. So I've introduced the test dependency for `fe-common` module as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
