Mryange opened a new pull request, #64307:
URL: https://github.com/apache/doris/pull/64307
### What problem does this PR solve?
ColumnVariant stores sparse and doc-value payloads as internal map columns
whose key/value data is not nullable, while the normal ColumnArray and
ColumnMap paths are expected to use nullable nested data. This mixed contract
can make manually constructed variant-internal maps look like ordinary nullable
maps.
Root cause: ColumnArray and ColumnMap did not encode nested nullability in
their concrete column type, so variant-specific not-null internal maps shared
the same runtime type as normal nullable maps.
This change introduces ColumnArrayImpl and ColumnMapImpl parameterized by
SubcolumnNullability, keeps ColumnArray and ColumnMap as the default nullable
aliases, and adds explicit ColumnArrayNotNull and ColumnMapNotNull aliases for
the variant-internal not-null use case. DataTypeMap::create_column() now
selects the physical column type from key/value nullability. Variant
sparse/doc-value columns are switched to ColumnMapNotNull, while generic
map/array operators keep using the nullable default path.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]