github-actions[bot] commented on code in PR #64314:
URL: https://github.com/apache/doris/pull/64314#discussion_r3380246595
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterGenerator.java:
##########
@@ -275,16 +273,12 @@ public PhysicalPlan
visitPhysicalHashJoin(PhysicalHashJoin<? extends Plan, ? ext
continue;
}
for (TRuntimeFilterType type : legalTypes) {
- //bitmap rf is generated by nested loop join.
Review Comment:
Removing the bitmap skip here lets `BITMAP` through whenever
`runtimeFilterType` already contains bit 16. `TRuntimeFilterType.values()`
still includes `BITMAP` and `SessionVariable.allowedRuntimeFilterType()` is
only a bitwise check, so a stale/global/programmatically-set value or an old FE
during rolling upgrade can produce a Nereids runtime filter with type `BITMAP`
for ordinary hash joins. `RuntimeFilter.toThrift()` will then serialize
`TRuntimeFilterType.BITMAP`, but BE `get_runtime_filter_type()` now throws
`Invalid runtime filter type` because the `BITMAP` case was removed. Please
keep `BITMAP` filtered out of all generic RF type enumerations, including this
hash/decoupled path and the set-operation stream below, rather than only
rejecting new user input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
