TsukiokaKogane commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3380712122
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##########
@@ -447,6 +475,74 @@ private Optional<LogicalPlan> handleMetaTable(TableIf
table, UnboundRelation unb
return Optional.of(new
LogicalTVFRelation(unboundRelation.getRelationId(), tvf, ImmutableList.of()));
}
+ private TBinlogScanType checkChangeScanCondition(OlapTable olapTable,
TableScanParams scanParams)
+ throws AnalysisException {
+ if (!olapTable.needRowBinlog()) {
+ throw new AnalysisException("INCR query requires ROW binlog
enabled on base table "
+ +
"(PROPERTIES('binlog.enable'='true','binlog.format'='ROW')). "
+ + "Table " + olapTable.getQualifiedName() + " doesn't
enable row binlog.");
+ }
+ HashSet<String> keys = new HashSet(scanParams.getMapParams().keySet());
+ keys.remove(OlapScanNode.OLAP_INCREMENT_TYPE);
+ keys.remove(OlapScanNode.OLAP_START_TIMESTAMP);
+ keys.remove(OlapScanNode.OLAP_END_TIMESTAMP);
+ if (!keys.isEmpty()) {
+ throw new ParseException("Unsupported parameter in incr query: " +
keys);
+ }
+ TBinlogScanType binlogScanType =
OlapScanNode.parseBinlogScanType(scanParams, olapTable);
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
