morrySnow commented on PR #63690:
URL: https://github.com/apache/doris/pull/63690#issuecomment-4667528105
⚠️ **Behavioral change: one-side pushdown now gated by `checkStats`.**
Previously, the old `PushDownAggThroughJoinOneSide` rule (deleted in this
PR) would push down aggregates through any join matching its pattern, without
requiring the `checkStats` heuristic to pass. Now ALL pushdown paths (one-side
and bilateral) go through `genAggregate()` which calls `checkStats()` with its
restrictive early return in `EagerAggRewriter.java`:
```java
if (!context.isPassThroughBigJoin() && !context.hasDecomposedAggIf) {
return false;
}
```
This means normal one-side pushdown through smaller joins (row count ≤ 400K)
will no longer happen unless `hasDecomposedAggIf` is true or
`eager_aggregation_mode > 0`. Please confirm this change is intentional and add
a note in the PR description about the expected impact on one-side pushdown
scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
