Copilot commented on code in PR #64362:
URL: https://github.com/apache/doris/pull/64362#discussion_r3386457589
##########
be/src/load/group_commit/group_commit_mgr.cpp:
##########
@@ -51,6 +51,21 @@ Status LoadBlockQueue::add_block(RuntimeState*
runtime_state, std::shared_ptr<Bl
bool write_wal, UniqueId& load_id) {
DBUG_EXECUTE_IF("LoadBlockQueue.add_block.failed",
{ return
Status::InternalError("LoadBlockQueue.add_block.failed"); });
+ DBUG_EXECUTE_IF("LoadBlockQueue.add_block.block_reuse_second", {
+ int seq = _debug_add_block_seq.fetch_add(1);
+ if (seq >= 1) {
+ LOG(INFO) << "debug hold reuse 2nd+ add_block, label=" << label
+ << ", load_id=" << load_id.to_string();
+ int64_t waited_ms = 0;
+ while (waited_ms < 10000 && DebugPoints::instance()->is_enable(
+
"LoadBlockQueue.add_block.block_reuse_second")) {
+ std::this_thread::sleep_for(std::chrono::milliseconds(10));
+ waited_ms += 10;
Review Comment:
New debug-point code uses `std::this_thread::sleep_for(...)`, but this
translation unit does not include `<thread>`. Relying on transitive includes is
not portable and can break compilation on some toolchains; please add `#include
<thread>` alongside the other standard headers at the top of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
