BiteTheDDDDt commented on code in PR #64010:
URL: https://github.com/apache/doris/pull/64010#discussion_r3387135476
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -1002,7 +928,7 @@ Status SegmentIterator::_apply_ann_topn_predicate() {
VLOG_DEBUG << fmt::format("Try apply ann topn: {}",
_ann_topn_runtime->debug_string());
size_t src_col_idx = _ann_topn_runtime->get_src_column_idx();
- ColumnId src_cid = _schema->column_id(src_col_idx);
+ ColumnId src_cid = _project_schema->column_id(src_col_idx);
Review Comment:
这里用 _project_schema 是对的。_ann_topn_runtime->get_src_column_idx() 来自
VSlotRef::column_id()，而这个值是 RowDescriptor::get_column_id(slot_id) 得到的 block
ordinal，不是 tablet schema column id。ANN 这里需要把“project/intermediate block
的位置”翻译成真实 column id 后再访问 _index_iterators[src_cid]，所以应该用 project schema。补充了注释。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
