liaoxin01 commented on code in PR #64383:
URL: https://github.com/apache/doris/pull/64383#discussion_r3392913688
##########
be/src/storage/segment/segment.cpp:
##########
@@ -240,10 +241,12 @@ Status Segment::_open(OlapReaderStatistics* stats) {
}
Status Segment::_open_index_file_reader() {
+ // Use `_seg_path` (the path passed to `open`) rather than
`_file_reader->path()` to derive the
+ // index file path prefix. `_file_reader->path()` may be normalized to an
absolute path, which
Review Comment:
Right, "may be" was imprecise. The behavior is deterministic per FS type:
for remote file systems (e.g. S3) `_file_reader->path()` returns the normalized
absolute path (with scheme/bucket prefix), while local FS keeps the relative
path. Reworded the comment to state this. The fix doesn't depend on it though —
using `_seg_path` always derives the index path from the same relative path
that PackedFileSystem's index map is keyed by.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
