morrySnow commented on code in PR #64361:
URL: https://github.com/apache/doris/pull/64361#discussion_r3393109755
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -992,6 +992,21 @@ class Suite implements GroovyInterceptable {
throw new RuntimeException("dictionary ${dictName} are not ready,
status: ${result}")
}
+ void waitForColocateGroupStable(String groupName, int timeoutSeconds = 60)
{
+ waitForColocateGroupStable(context.dbName, groupName, timeoutSeconds)
+ }
+
+ void waitForColocateGroupStable(String dbName, String groupName, int
timeoutSeconds = 60) {
+ String fullGroupName = "${dbName}.${groupName}"
Review Comment:
Fixed in 8e8fc36da54. Global colocate group names starting with __global__
are now kept unprefixed, matching ColocateTableIndex.GroupId.getFullGroupName.
##########
regression-test/suites/correctness_p0/test_colocate_join_of_column_order.groovy:
##########
@@ -68,6 +68,7 @@ suite("test_colocate_join_of_column_order") {
sql("select * from test_colocate_join_of_column_order_t1 a join
test_colocate_join_of_column_order_t2 b on a.k1=b.k2 and a.v=b.v;")
notContains "COLOCATE"
}
+ waitForColocateGroupStable("group_column_order")
Review Comment:
Fixed in 8e8fc36da54. The stability wait now runs before the first EXPLAIN,
so both negative and positive column-order assertions execute with a stable
colocate group. The target regression suite passes after a clean framework
rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
