deardeng commented on code in PR #63818:
URL: https://github.com/apache/doris/pull/63818#discussion_r3393208867


##########
be/src/io/cache/peer_file_cache_reader.cpp:
##########
@@ -125,7 +234,9 @@ Status PeerFileCacheReader::fetch_blocks(const 
std::vector<FileBlockSPtr>& block
     }};
 

Review Comment:
   Let's keep it as is for now — deriving the client timeout from 
peer_server_cache_fill_timeout_ms adds complexity, and since the requester and 
the peer are different BEs, there's no guarantee both sides have the same 
config value anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to