Copilot commented on code in PR #64402:
URL: https://github.com/apache/doris/pull/64402#discussion_r3393800214
##########
regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy:
##########
@@ -210,7 +211,7 @@ suite("insert_group_commit_into_max_filter_ratio") {
sql """ set group_commit = async_mode; """
sql """ set enable_insert_strict = false; """
group_commit_insert """ insert into ${dbTableName} values (9, 'a',
'a'); """, 1
- get_row_count_with_retry(8)
+ get_row_count_with_retry(7)
Review Comment:
`get_row_count_with_retry` only loops until the count is >= expected, but it
never asserts at the end. If the expected count is never reached (e.g., async
publish stuck), the test will still pass silently. Add a post-check assertion
here to make the test actually fail when the row count doesn't meet the
expectation.
##########
regression-test/suites/insert_p0/insert_group_commit_into_max_filter_ratio.groovy:
##########
@@ -183,15 +184,15 @@ suite("insert_group_commit_into_max_filter_ratio") {
sql """ set enable_insert_strict = false; """
group_commit_insert """ insert into ${dbTableName} values (5, 'abc',
10); """, 0
- // The row 6 and 7 is different between legacy and nereids
try {
sql """ set group_commit = off_mode; """
- sql """ set enable_insert_strict = true; """
+ sql """ set enable_strict_cast = true; """
sql """ insert into ${dbTableName} values (6, 'a', 'a'); """
Review Comment:
The try/catch that is meant to validate strict cast behavior does not fail
the test when the INSERT unexpectedly succeeds (i.e., no exception thrown).
This makes the case unable to detect regressions where strict cast stops
throwing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
