github-actions[bot] commented on code in PR #64277:
URL: https://github.com/apache/doris/pull/64277#discussion_r3395010712
##########
.github/workflows/build-extension.yml:
##########
@@ -130,6 +130,25 @@ jobs:
- name: Build cdc client
run: |
cd fs_brokers/cdc_client/ && /bin/bash build.sh
+ test-cdc-client:
+ name: Test Cdc Client
+ needs: changes
+ if: ${{ needs.changes.outputs.cdc_client_changes == 'true' }}
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout ${{ github.ref }}
+ uses: actions/checkout@v3
+
+ - name: Setup java
+ uses: actions/setup-java@v2
+ with:
+ distribution: adopt
+ java-version: '17'
+
+ - name: Run cdc client integration tests
+ run: |
+ cd fe && mvn -Pflatten install -pl fe-common -Dskip.doc=true
-DskipTests -Dmaven.build.cache.enabled=false
+ cd ../fs_brokers/cdc_client && mvn -B test-compile
failsafe:integration-test failsafe:verify
# build-docs:
Review Comment:
This command compiles the new unit tests but never runs them. `test-compile`
stops before Surefire, and the Failsafe plugin is configured to include only
`**/*ITCase.java`, so added tests such as `BatchRecordBufferTest`,
`DebeziumConvertInternalTest`, and `ConfigUtilTest` can fail while this job
stays green. Please run the Surefire phase as part of this job, for example:
```suggestion
cd ../fs_brokers/cdc_client && mvn -B test
failsafe:integration-test failsafe:verify
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
