github-actions[bot] commented on code in PR #64366:
URL: https://github.com/apache/doris/pull/64366#discussion_r3395483814
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java:
##########
@@ -134,6 +138,10 @@ public FoldConstantRuleOnFE(boolean deepRewrite) {
}
Review Comment:
This helper still has callers that intentionally pass a null rewrite
context. `FrontendConjunctsUtils.isFiltered()` replaces slots with literals and
then calls `FoldConstantRuleOnFE.evaluate(rewrittenExpr, null)`; with this new
unconditional dereference, that path throws before folding, is caught in
`FrontendConjunctsUtils`, and returns false. That disables frontend metadata
conjunct filtering and breaks existing cases such as
`FrontendConjunctsUtilsTest` expecting `c1 = 2` with value `3` to be filtered.
Please make this debug-skip check null-safe, matching the pattern in
`FoldConstantRule.evaluate`, or keep it only in rule matching where a
`CascadesContext` is guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
