github-actions[bot] commented on code in PR #64409:
URL: https://github.com/apache/doris/pull/64409#discussion_r3399999916
##########
regression-test/suites/statistics/test_hot_value.groovy:
##########
@@ -211,5 +211,112 @@ suite("test_hot_value") {
assertEquals(1, result.size())
assertEquals("' : ;a':1.0", result[0][17])
- sql """drop database if exists test_hot_value"""
+ sql """set enable_dphyp_optimizer=true"""
+ sql """
+ WITH cte1 AS (
+ SELECT
+ MAX(t0.`col_value`) as `col_value`,
+ COUNT(1) as `count`,
+ SUM(`len`) as `column_length`
+ FROM
+ (
+ SELECT
+ xxhash_64(SUBSTRING(CAST(`value1` AS STRING), 1, 1024)) AS
`hash_value`,
+ `value1` AS `col_value`,
+ LENGTH(`value1`) as `len`,
+ assert_true(
+ `value1` IS NULL
+ OR LENGTH(`value1`) <= 1024,
+ 'ANALYZE_SKIP_LONG_STRING_COLUMN'
+ ) AS `__lc`
+ FROM
+ `internal`.`test_hot_value`.`test1` TABLET(1781162157680)
Review Comment:
This makes the regression non-deterministic. `test1` is created earlier in
this suite, and Doris assigns its tablet ids at create time; `1781162157680` is
just a catalog id from one environment and will not exist on a fresh CI
cluster. The query will fail during analysis with an unknown/non-matching
tablet before it reaches the DPHyp rewrite path this PR is trying to test.
Please either remove the `TABLET` hint or derive it at runtime, e.g. from `SHOW
TABLETS FROM test1` as other tablet tests do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
