github-actions[bot] commented on code in PR #64390:
URL: https://github.com/apache/doris/pull/64390#discussion_r3400696766
##########
thirdparty/build-thirdparty.sh:
##########
@@ -33,6 +33,8 @@ set -eo pipefail
curdir="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
+TP_CXX_STANDARD=20
Review Comment:
This still leaves a concrete mixed-standard Protobuf path in the final BE
link. The default package order builds `protobuf` with `TP_CXX_STANDARD=20`,
but then builds `brpc` later against `${TP_INSTALL_DIR}/include` and
`${TP_INSTALL_DIR}/lib/libprotobuf.a` without passing this standard. Upstream
brpc 1.4.0 calls `use_cxx11()` and unconditionally sets C++11, and it compiles
generated protobuf objects (`PROTO_LIB`) from its `.proto` files; Doris then
imports `libbrpc.a` into `COMMON_THIRDPARTY` and links it with the C++20 BE.
Protobuf headers also contain standard-dependent inline/template code (for
example the `__cplusplus`/string_view/constinit/nodiscard paths), so this PR
still leaves C++11 and C++20 Protobuf header code in the same binary. Please
make `brpc` respect `TP_CXX_STANDARD` as well, including an upstream patch
because a plain `-DCMAKE_CXX_STANDARD=20` would be overwritten by brpc's CMake.
The same audit should cover other Protobuf consumers linked into BE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
