github-actions[bot] commented on code in PR #64423:
URL: https://github.com/apache/doris/pull/64423#discussion_r3401060010
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java:
##########
@@ -766,7 +789,21 @@ public void clearRunningStreamTask(JobStatus newJobStatus)
{
log.info("clear running streaming insert task for job {}, task {},
status {} ",
getJobId(), runningStreamTask.getTaskId(),
runningStreamTask.getStatus());
runningStreamTask.cancel(JobStatus.STOPPED.equals(newJobStatus) ?
false : true);
- runningStreamTask.closeOrReleaseResources();
+ // Reader release for manual pause is driven by the command entry;
failure pause keeps it for reuse.
Review Comment:
This removal also changes the TVF-backed path. On a manual pause of a
`StreamingInsertTask`, `clearRunningStreamTask()` calls `cancel()`, which sets
status to `CANCELED`; then `AbstractStreamingTask.execute()` skips its finally
cleanup, and `StreamingInsertTask.cancel()` only cancels the `StmtExecutor`
without clearing `stmtExecutor`, `taskCommand`, or `ctx`. Previously this
explicit `closeOrReleaseResources()` cleared those local references. Please
keep local task cleanup for non-CDC tasks (or split CDC reader release from
local resource cleanup) so TVF streaming jobs do not retain the canceled task's
`ConnectContext`/executor after pause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
