github-actions[bot] commented on code in PR #63330:
URL: https://github.com/apache/doris/pull/63330#discussion_r3403888140
##########
build.sh:
##########
@@ -364,9 +364,9 @@ if [[ ! -f
"${DORIS_THIRDPARTY}/installed/lib/${LAST_THIRDPARTY_LIB}" ]]; then
rm -rf "${DORIS_THIRDPARTY}/installed"
if [[ "${CLEAN}" -eq 0 ]]; then
- "${DORIS_THIRDPARTY}/build-thirdparty.sh" -j "${PARALLEL}"
+ bash "${DORIS_THIRDPARTY}/build-thirdparty.sh" -j "${PARALLEL}"
else
Review Comment:
This fixes the thirdparty invocation, but the same top-level build path
still has a reachable Doris-owned script execution that bypasses `bash`: when
`DORIS_BUILD_PROFILE=1`, `build.sh` runs `"${DORIS_HOME}/build_profile.sh"`
directly in the collect/trap/final-record calls. In a checkout where executable
bits are missing, `DORIS_BUILD_PROFILE=1 bash build.sh --be` fails with
`Permission denied` before reaching the fixed build steps, so the PR does not
fully fix the stated build-path problem. This is distinct from the existing CDC
thread because that was the nested CDC `generated-source.sh` call; this is the
optional top-level build profiling path. Please invoke `build_profile.sh`
through `bash` in those calls too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
