englefly commented on code in PR #64330:
URL: https://github.com/apache/doris/pull/64330#discussion_r3407194307
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpProjectExprUnderTopN.java:
##########
@@ -244,6 +244,18 @@ private static void collectFromNode(Plan node, PullUpInfo
info, Set<ExprId> bloc
for (NamedExpression ne : project.getProjects()) {
if (canPullUp(ne) && !blockedExprIds.contains(ne.getExprId()))
{
info.addPulledUpExpr(project, ne);
+ } else if (ne instanceof Alias && ne.child(0) instanceof Slot)
{
Review Comment:
这段代码有重构. 新版本中这里只处理 不能 canPullUp 的 ne, 且 ne 是 slot as x 的形式.如果是 expr as x,
那么会在其他分支处理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
