heguanhui commented on code in PR #64484: URL: https://github.com/apache/doris/pull/64484#discussion_r3410786733
########## be/src/storage/tablet/tablet_meta.cpp: ########## Review Comment: Thanks for the suggestion. However, `TTabletSchema` currently doesn't have `binlog_lsn_col_idx` and `binlog_timestamp_col_idx` fields. Adding them would require modifying Thrift definitions and FE code, which is a larger change. This PR focuses on fixing the coredump in BE UT with minimal changes. Computing the indices by column name is consistent with how other special columns (like `delete_sign_idx`) are handled when `TTabletSchema` doesn't provide them directly. If you prefer, I can create a follow-up PR to add these fields to `TTabletSchema` and pass them from FE to BE. But for this PR, the dynamic approach works and is safe. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
