github-actions[bot] commented on code in PR #63690:
URL: https://github.com/apache/doris/pull/63690#discussion_r3411609517
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -2345,6 +2347,29 @@ public boolean isEnableHboNonStrictMatchingMode() {
)
private int eagerAggregationMode = 0;
Review Comment:
`force_eager_agg_hint` affects the optimizer's pushdown decisions, but this
new session variable is not included in the forwarded variable set. If a
statement is forwarded to another FE for planning, the receiver keeps the
default empty `forceEagerAggHintMap`, so `SET force_eager_agg_hint = ...` can
silently stop taking effect. Adjacent plan-affecting controls such as
`eager_aggregation_mode` and `disable_nereids_rules` are marked `needForward =
true`; this one should be forwarded as well. The forwarded restore path calls
`VariableMgr.setValue()`, so the custom setter will keep the parsed map in sync.
```suggestion
@VarAttrDef.VarAttr(name = "force_eager_agg_hint", setter =
"setForceEagerAggHint", needForward = true,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
