github-actions[bot] commented on code in PR #63781: URL: https://github.com/apache/doris/pull/63781#discussion_r3417645871
########## regression-test/data/load_p0/insert/test_scan_filtered_rows_not_pollute_load_counter.out: ########## @@ -0,0 +1,15 @@ +-- This file is automatically generated. You should know what you did if you want to edit this +-- !insert_empty -- +0 + +-- !insert_empty_profile -- +0 + +-- !delete_noop -- +3 + +-- !update_noop -- +1 1 +2 2 +3 3 + Review Comment: `git diff --check` reports this generated result file as `new blank line at EOF`. Please regenerate or trim the trailing empty line so the patch passes the repository whitespace check. ########## regression-test/suites/load_p0/insert/test_scan_filtered_rows_not_pollute_load_counter.groovy: ########## @@ -0,0 +1,94 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_scan_filtered_rows_not_pollute_load_counter", "p0") { + // Rows filtered by scan predicates of a query must not be counted as load + // "unselected" rows. Otherwise loadedRows reported to FE becomes negative + // (total 0 - unselected N) and the insert fails with errors like + // "Insert has too many filtered data 0/-10 insert_max_filter_ratio is 1.000000". Review Comment: The regression-test standard in `AGENTS.md` says ordinary simple test tables should not use `def tableName` indirection; the table names should be hardcoded in the SQL. This suite uses variables for all three ordinary tables, which makes the new test inconsistent with that rule. Please inline the literal table names throughout the SQL statements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
