This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-4.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-4.1 by this push:
new 8a619d717db [fix](case) check_hash_bucket_table: quote db/table
identifiers (#64510)
8a619d717db is described below
commit 8a619d717db4295120682463b34e4abb37011d79
Author: shuke <[email protected]>
AuthorDate: Tue Jun 16 13:22:16 2026 +0800
[fix](case) check_hash_bucket_table: quote db/table identifiers (#64510)
## Problem
This global check iterates over **all** databases/tables and builds
statements like `show create table ${tblName}` without backticks. When
another suite leaves behind a table named with a reserved word (e.g.
`order`), the statement becomes `show create table order` → `mismatched
input 'order'`, which fails the whole check. This only triggers under
the full P0 pipeline (cross-suite residue), not when the suite runs in
isolation.
## Fix
Backtick all db / table / partition identifiers (`use`, `desc`, `show
create table`, `show partitions`, `show replica status`, and the `select
... from db.table`).
## Verification
Ran the suite on a branch-4.1 local cluster — passes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
---
.../check_hash_bucket_table/check_hash_bucket_table.groovy | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
a/regression-test/suites/check_hash_bucket_table/check_hash_bucket_table.groovy
b/regression-test/suites/check_hash_bucket_table/check_hash_bucket_table.groovy
index e1b38057da3..3fe6713f66b 100644
---
a/regression-test/suites/check_hash_bucket_table/check_hash_bucket_table.groovy
+++
b/regression-test/suites/check_hash_bucket_table/check_hash_bucket_table.groovy
@@ -36,12 +36,12 @@ suite("check_hash_bucket_table") {
def bucketColumns = info["DistributionKey"]
if (bucketColumns == "RANDOM") {return false}
- def columnsDetail = sql_return_maparray "desc ${tblName} all;"
+ def columnsDetail = sql_return_maparray "desc `${tblName}` all;"
def bucketCols = bucketColumns.split(",").collect { it.trim() }
def bucketColsStr = bucketCols.collect { "`${it}`" }.join(",")
def partitionName = info["PartitionName"]
try {
- def tabletIdList = sql_return_maparray(""" show replica status
from ${tblName} partition(${partitionName}); """).collect { it.TabletId
}.toList()
+ def tabletIdList = sql_return_maparray(""" show replica status
from `${tblName}` partition(`${partitionName}`); """).collect { it.TabletId
}.toList()
def tabletIds = tabletIdList.toSet()
int replicaNum = tabletIdList.stream().filter { it ==
tabletIdList[0] }.count()
logger.info("""===== [check] Begin to check partition:
${db}.${tblName}, partition name: ${partitionName}, bucket num: ${bucketNum},
replica num: ${replicaNum}, bucket columns: ${bucketColsStr}""")
@@ -50,7 +50,7 @@ suite("check_hash_bucket_table") {
tabletIds.each { it2 ->
def tabletId = it2
try {
- def res = sql "select crc32_internal(${bucketColsStr})
% ${bucketNum} from ${db}.${tblName} tablet(${tabletId}) group by
crc32_internal(${bucketColsStr}) % ${bucketNum};"
+ def res = sql "select crc32_internal(${bucketColsStr})
% ${bucketNum} from `${db}`.`${tblName}` tablet(${tabletId}) group by
crc32_internal(${bucketColsStr}) % ${bucketNum};"
if (res.size() > 1) {
logger.info("""===== [check] check failed:
${db}.${tblName}, partition name: ${partitionName}, tabletId: ${tabletId},
bucket columns: ${bucketColsStr}, res.size()=${res.size()}, res=${res}""")
assert res.size() == 1
@@ -73,9 +73,9 @@ suite("check_hash_bucket_table") {
}
def checkTable = { String db, String tblName ->
- sql "use ${db};"
- def showStmt = sql_return_maparray("show create table
${tblName}")[0]["Create Table"]
- def partitionInfo = sql_return_maparray """ show partitions from
${tblName}; """
+ sql "use `${db}`;"
+ def showStmt = sql_return_maparray("show create table
`${tblName}`")[0]["Create Table"]
+ def partitionInfo = sql_return_maparray """ show partitions from
`${tblName}`; """
int checkedPartition = 0
partitionInfo.each {
if (checkPartition(db, tblName, it)) {
@@ -88,7 +88,7 @@ suite("check_hash_bucket_table") {
}
def checkDb = { String db ->
- sql "use ${db};"
+ sql "use `${db}`;"
dbNum.incrementAndGet()
def tables = sql("show full tables").stream().filter{ it[1] == "BASE
TABLE" }.collect{ it[0] }.toList()
def asyncMVs = sql_return_maparray("""select * from
mv_infos("database"="${db}");""").collect{ it.Name }.toSet()
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
