Copilot commented on code in PR #64554:
URL: https://github.com/apache/doris/pull/64554#discussion_r3418747678
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -445,6 +445,15 @@ void
CloudStorageEngine::_refresh_storage_vault_info_thread_callback() {
while (!_stop_background_threads_latch.wait_for(
std::chrono::seconds(config::refresh_s3_info_interval_s))) {
sync_storage_vault();
+ // The S3 rate limiter is only rebuilt inside
S3ClientFactory::create(), which is not
+ // called when an existing vault's conf is unchanged. Check it here so
that dynamically
+ // modified s3_{get,put}_* rate limiter configs take effect within
+ // refresh_s3_info_interval_s even when no vault is created or its
conf does not change.
+ // Gate it behind enable_s3_rate_limiter so that clusters with rate
limiting disabled
Review Comment:
The comment says the S3 rate limiter is "only" rebuilt inside
`S3ClientFactory::create()`, but this thread now also triggers rebuilds via
`check_s3_rate_limiter_config_changed()`. Please reword to avoid misleading
future readers/debuggers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
