Copilot commented on code in PR #64574: URL: https://github.com/apache/doris/pull/64574#discussion_r3422230116
########## be/src/util/bthread_shared_mutex.h: ########## @@ -0,0 +1,118 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <bthread/condition_variable.h> +#include <bthread/mutex.h> + +#include <climits> +#include <mutex> + +namespace doris { + +// A reader-writer lock for bthread contexts. It is a port of libc++'s +// std::shared_mutex (the two-gate condition-variable algorithm) onto +// bthread::Mutex/bthread::ConditionVariable. Unlike std::shared_mutex +// (pthread_rwlock_t), ownership carries no OS-thread identity, so it is safe to +// lock on one bthread worker and unlock on another after a bthread migrates. +// Satisfies the C++ SharedMutex requirements (usable with std::unique_lock / +// std::shared_lock). Writer-preferring. +class BthreadSharedMutex { Review Comment: `BthreadSharedMutex` is a new concurrency primitive that replaces the tablet header lock and is security-/correctness-critical (e.g., cross-worker unlock safety, shared vs exclusive behavior, writer/readers interaction). It would be valuable to add a dedicated unit test (under be/test/util/) covering basic shared/exclusive semantics and specifically reproducing the original issue pattern (lock in one pthread/bthread context, unlock in another) to guard against regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
