yifanwu-sys commented on PR #64644:
URL: https://github.com/apache/doris/pull/64644#issuecomment-4748244610

   Thanks for the reminder. I have clarified the PR description below.
   
   ### What problem was fixed?
   
   This PR fixes a documentation rendering inconsistency in the README social 
media badge section.
   
   In some localized README files, the Slack link was written as an empty 
anchor:
   
   ```html
   <a href="https://doris.apache.org/slack"; height=25></a>
   ```
   
   Because the anchor did not contain an `<img>` element, the Slack badge was 
not visible when the README was rendered.
   
   `docs/zh-CN/README.md` already had the correct implementation, so I used it 
as the reference.
   
   ### How was it fixed?
   
   I added the missing Slack badge image element to the affected README files:
   
   ```html
   <a href="https://doris.apache.org/slack";><img 
src="https://img.shields.io/badge/-Slack-4A154B?style=social&logo=slack"; 
height=25 alt="Slack"></a>
   ```
   
   The change keeps the Slack badge consistent with the existing Twitter and 
Medium badges in the same social media section.
   
   ### What behavior was changed?
   
   Before this PR:
   
   * The Slack anchor existed, but it was empty.
   * The Slack badge was invisible in the affected README files.
   
   After this PR:
   
   * The Slack badge is visible.
   * Users can see and access the Slack community link from the rendered README.
   * The localized README files are consistent with the already-correct 
`docs/zh-CN/README.md`.
   
   ### Why was it modified?
   
   The modification was made to fix the missing visual badge and keep the 
README social media section consistent across localized versions.
   
   ### Possible impact
   
   This is a documentation-only change.
   
   It does not affect:
   
   * Doris build behavior;
   * runtime behavior;
   * SQL behavior;
   * storage behavior;
   * query execution;
   * compatibility.
   
   ### New features
   
   No new feature is added.
   
   ### Refactoring
   
   No code was refactored.
   
   ### Optimization
   
   No runtime or functional optimization was made. This PR only fixes the 
missing Slack badge image in README files.
   
   ### Verification
   
   I verified that:
   
   * the affected README files now contain the Slack badge image;
   * no README file still uses the empty Slack anchor;
   * `docs/zh-CN/README.md` was not modified because it already had the correct 
implementation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to