deardeng opened a new pull request, #64647:
URL: https://github.com/apache/doris/pull/64647

   PR #60467 added a non-snapshot txn->get(table_version_key) in commit_txn, 
commit_partition, commit_index and drop_partition to return table_version+1 to 
FE as a version-cache hint. A non-snapshot read adds table_version_key to the 
transaction's read-conflict range, while update_table_version() bumps the same 
key via atomic_add (otherwise conflict-free). As a result, concurrent 
commits/imports on the same table now conflict on the version key and fail with 
KV_TXN_CONFLICT, causing retries and throughput regression.
   
   Change these reads to snapshot reads. The returned value is only a hint for 
FE's version cache (reconciled by CloudTableAndPartitionVersionChecker) and the 
real increment is still done by atomic_add, so correctness is preserved while 
the read-conflict on the version key is removed.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [x] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [x] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to