yiguolei commented on code in PR #64632:
URL: https://github.com/apache/doris/pull/64632#discussion_r3449451325
##########
be/src/core/data_type_serde/data_type_serde.h:
##########
@@ -546,11 +546,12 @@ inline static NullMap revert_null_map(const NullMap*
null_bytemap, size_t start,
return res;
}
-inline Status checkArrowStatus(const arrow::Status& status, const std::string&
column,
- const std::string& format_name) {
+template <typename ColumnType, typename BuilderType>
+inline Status checkArrowStatusWithContext(const arrow::Status& status, const
ColumnType& column,
Review Comment:
继续叫这个checkArrowStatus 名字吧。 加了context 这个后缀之后，我们实际也没context 这个参数，容易迷茫
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
