924060929 commented on PR #61828: URL: https://github.com/apache/doris/pull/61828#issuecomment-4764398619
Addressed both review comments in 440189dd3e4: 1. **Marker placement**: moved `IS_PROFILE_COLLECTION_COMPLETED` from `SummaryProfile.queryFinished()` to `Profile.shouldStoreToStorage()`, which checks `ExecutionProfile.isCompleted()` for all fragments. Marker is now written at the actual collection-completed condition (including the timeout path). 2. **Regression test**: removed final `DROP TABLE` per Doris test conventions. run buildall /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
