github-actions[bot] commented on code in PR #64604:
URL: https://github.com/apache/doris/pull/64604#discussion_r3449712970
##########
be/src/load/channel/tablets_channel.cpp:
##########
@@ -629,16 +629,17 @@ Status BaseTabletsChannel::_write_block_data(
// add_batch may concurrency with inc_open but not under _lock.
// so need to protect it with _tablet_writers_lock.
- decltype(_tablet_writers.find(tablet_id)) tablet_writer_it;
+ BaseDeltaWriter* tablet_writer = nullptr;
Review Comment:
This change is specifically fixing a race between `_write_block_data` and
`incremental_open`, but the PR does not add a test that exercises that path.
The cited `LoadStreamMapPoolTest.*` only validates `LoadStreamMapPool` object
reuse/release counts and never instantiates `TabletsChannel`, calls
`incremental_open`, or drives `_write_block_data`. Please add a targeted BE
test, or at least update the test evidence with an existing test that actually
covers concurrent incremental-open insertion while add-batch looks up
`_tablet_writers`; otherwise this lock/lifetime contract can regress without
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
