github-actions[bot] commented on code in PR #64665:
URL: https://github.com/apache/doris/pull/64665#discussion_r3449887214
##########
.github/workflows/code-review-runner.yml:
##########
@@ -141,27 +141,37 @@ jobs:
OSS_CODEX_AUTH_OBJECT: oss://doris-community-ci/codex/auth.json
- name: Sync Codex memories from OSS
- continue-on-error: true
run: |
install -m 700 -d "$CODEX_HOME/memories"
archive="$RUNNER_TEMP/codex-memories.tar.gz"
+ listing="$RUNNER_TEMP/codex-memories.list"
if ossutil -i "$OSS_AK" -k "$OSS_SK" -e "$OSS_ENDPOINT" cp -f
"$OSS_CODEX_MEMORIES_OBJECT" "$archive"; then
- tar -tzf "$archive" | awk '
- $0 != "memories" && $0 !~ /^memories\// { bad = 1 }
- END { exit bad }
- '
- tar -xzf "$archive" -C "$CODEX_HOME"
- install -m 700 -d "$CODEX_HOME/memories"
- chmod -R go-rwx "$CODEX_HOME/memories" || true
+ if [ -s "$archive" ]; then
+ tar -tzf "$archive" > "$listing"
Review Comment:
This restore step is still an optional cache/bootstrap path, but the PR
removed `continue-on-error` and now runs `tar -tzf`/validation/extraction
directly under the default `bash -e` workflow shell. If the central
`memories.tar.gz` object is present but corrupt, partially written, or has an
unexpected entry, this step exits before `codex exec` starts. Missing and empty
memory already fall back to an empty memory directory, so a bad auxiliary
archive should do the same instead of bricking every `/review` run until the
OSS object is fixed. Please keep the restore best-effort for
validation/extraction failures, for example by warning and recreating an empty
`$CODEX_HOME/memories`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
