924060929 commented on code in PR #63366:
URL: https://github.com/apache/doris/pull/63366#discussion_r3449986962
##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/SummaryProfile.java:
##########
@@ -563,6 +567,10 @@ public void update(Map<String, String> summaryInfo) {
// This method is used to display the final data status when the overall
query ends.
// This can avoid recalculating some strings and so on every time during
the update process.
public void queryFinished() {
+ // Mark profile collection as complete. This is written last, after
all BE fragment
+ // profiles have been merged (called post-waitForFragmentsDone).
Pollers can wait for
+ // this field to avoid reading a partial profile.
Review Comment:
Update: after rebasing onto latest master I noticed this marker fully
duplicated master's #64392 (`Profile Completion State`:
RUNNING/COLLECTING/COMPLETE, wired in `Profile.java`, tested in
`ProfileManagerTest`), and ours had no reader. So instead of moving it, I
**removed `IS_PROFILE_COLLECTION_COMPLETED` entirely** (commit `7fdb989a3a7`)
and made the profile-plan-tree test plugin poll master's `Profile Completion
State: COMPLETE` instead of a fixed sleep. The ordering concern is moot now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
