gavinchou commented on code in PR #63376:
URL: https://github.com/apache/doris/pull/63376#discussion_r3456718902
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -145,6 +145,31 @@ size_t NeedUpdateLRUBlocks::drain(size_t limit,
std::vector<FileBlockSPtr>* outp
return drained;
}
+size_t NeedUpdateLRUBlocks::remove(const UInt128Wrapper& hash) {
Review Comment:
there are performance issues
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -145,6 +145,31 @@ size_t NeedUpdateLRUBlocks::drain(size_t limit,
std::vector<FileBlockSPtr>* outp
return drained;
}
+size_t NeedUpdateLRUBlocks::remove(const UInt128Wrapper& hash) {
Review Comment:
do we really need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
